Uwe Stöhr wrote:
>> Uwe can you give a more precise description where from are the numbers 684 
>> / 630
>> inside the following code? :

i was going to look what are the values here, but my lyx crashes when i go to
horizontal line dialog, backtrace below.
#2  0xb6f8d348 in abort () from /lib/libc.so.6
#3  0x087c224c in lyx::frontend::GuiLine::dialogToParams() const ()
#4  0x0867cf9f in lyx::frontend::InsetParamsDialog::checkWidgets(bool) ()
#5  0x0867d45a in 
lyx::frontend::InsetParamsDialog::on_synchronizedViewCB_stateChanged(int) ()
#6  0x0867d754 in 
lyx::frontend::InsetParamsDialog::InsetParamsDialog(lyx::frontend::GuiView&, 
lyx::frontend::InsetParamsWidget*) ()
#7  0x0867da32 in lyx::frontend::createDialog(lyx::frontend::GuiView&, 
lyx::InsetCode) ()
#8  0x0867da79 in lyx::frontend::createDialog(lyx::frontend::GuiView&, 
std::string const&) ()
#9  0x086419f4 in lyx::frontend::GuiView::build(std::string const&) ()
#10 0x0864968f in lyx::frontend::GuiView::findOrBuild(std::string const&, bool)

when i enabled debuging symbols on, the crash disappeared though.
so i can't give more precise backtrace, sorry.

>> + // FIXME: this is a hack to get the mi.base.textwidth but
>> + // text_metrics_.width() is 1.0857 * mi.base.textwidth
>> + // ( 1.0857 = 684 / 630 )
>> + pi_.base.textwidth = int(0.92 * text_metrics_.width());
>
> I need mi.base.textwidth in LineInset::draw. JMarc told me how to acces it 
> via text_metrics_.width() in rowpainter.cpp. But
> text_metrics_.width() gives 684

my box gives 686.

>>> I nevertheless committed the patch hoping that this issues can be solved
>>> soon.
>>
>> i wonder who is going to do it once the code is committed :(
>
> JMarc, Vincent, Abdel? OK, committing this hack is not perfect but it works 
> (at least on my PC)

well, nobody reacted as you hoped. what do you propose now?



few other glitches i saw:
- no focus in dialog set up initially
- there should be some implicit value in boxes, which are generally sensible
  (best would be such values, which would repeat the behaviour of 1.6
  version of horizontal line).
- if i set big offset by mistake like, like 1 cm it has very strange painting
  results and interfering randomly with tezt/insetss around. moreover the
  typeset looks completely different. i guess some geometry stuff is broken.

pavel

Reply via email to