Uwe Stöhr wrote: >> when i enabled debuging symbols on, the crash disappeared though. >> so i can't give more precise backtrace, sorry. > > Abdel, it didn't crash before you transformed the dialog from CommandInset > to InsetWidgets.
do you understand why the code in r35299 string width_str = fromqstr(WidthLE->text()); if (width_str[0] == '-') width_str.erase(0,1); must crash sooner or later? (this idiom repeats more times in the code) the sad thing is that as well as the magic constants monster these lines were not in the patch you have asked in the list. what is the point of asking for review, when you commit different things? >> well, nobody reacted as you hoped. what do you propose now? > > Give me some time please. no problem, but the message has red bullet in my mailbox and i'm not gonna to forget on it if you hope so :) i will reply to the rest of questions once the crashes are gone. maybe things will improve by then. pavel >> few other glitches i saw: >> - no focus in dialog set up initially > > Abdel? > >> - there should be some implicit value in boxes, which are generally >> sensible >> (best would be such values, which would repeat the behaviour of 1.6 >> version of horizontal line). > > I don't understand. The default values when inserting a horizontal line are > those of the old \lyxline. > >> - if i set big offset by mistake like, like 1 cm it has very strange >> painting >> results and interfering randomly with tezt/insetss around. moreover the >> typeset looks completely different. i guess some geometry stuff is >> broken. > > I'm not on my box and thus cannot test, but when committed it worked well - > the line drawn on screen looked nearly as in the PDF output. Do you have a > LyX testfile for me? > > regards Uwe
