Re: latex linelen

[Vincent van Ravesteijn]

Tommaso Cucinotta schreef:
Tommaso Cucinotta ha scritto:
Vincent van Ravesteijn ha scritto:
anyone against this patch ? It uses OutputParams.linelen to control 
newlines also on LaTeX exports, additionally to plaintext ones.
Yes, I'm against.
You give no reason for doing this.
On a related note, the proposed patch gives a meaning to the line 2626 
of Buffer.cpp

void Buffer::getSourceCode(odocstream & os, pit_type par_begin,
   pit_type par_end, bool full_source) const
{
   OutputParams runparams(&params().encoding());
   runparams.nice = true;
   runparams.flavor = params().useXetex ?
       OutputParams::XETEX : OutputParams::LATEX;
   runparams.linelen = lyxrc.plaintext_linelen;

in case of a latex source code request (currently the linelen in the 
rc file is being used instead of the supplied one via OutputParams).

Sorry but I really can't see what is bad in having this 
runparams.linelen control also the line width of LaTeX exports.

 T.

I haven't said it was bad, I only (sort of) said that if you propose a 
patch, you can ease the process by telling why you want to do it and why 
it would be good.

It indeed looks a bit strange to have this hardcoded value instead of 
the runparams, so I think the patch is OK.

Vincent