Uwe Stöhr schreef:

> Is the attached OK ?

Currently we output this:

\textcolor{cyan}{one }\textcolor{cyan}{\emph{two}}\textcolor{cyan}{
three}

your patch changes it to:

\textcolor{cyan}{one }\textcolor{cyan}{\emph{two}}\textcolor{cyan}{{}
three}

I apologize for my confusing comment 2 in http://www.lyx.org/trac/ticket/4473 where I proposed this. I wrote in http://www.lyx.org/trac/ticket/4491 that the clean solution is:

\textcolor{cyan}{one \emph{two} three}

The solution of your patch with the brace pair also works but is a hack compared to the clean solution.
Of course it's a hack. The fact that textcolor is a bit buggy is reason enough to fix it with a hack.

while the clean code is simply

\emph{one \textbf{two} three}
Yes I understand, but this does not fit in the current code we have. To do this would require a lot of rewriting. I'm now only interested in fixing this bug which caused me to get some grumpy reviewers for a paper, because of a number of spaces missing.

This bug is too important to wait for someone willing to rewrite the code, which is noone, which causes the bug to collect dust for over a year.

By the way, this is NOT the same as bug #4493. Please do not start closing bugs that I'm trying to fix without any discussion.


regards Uwe
Vincent

Reply via email to