Vincent van Ravesteijn wrote: > I just forgot adding 'update', but it is basically the same. And I was > trying to add a checkout command. It works quite well, except that LyX does > not which file top open. Maybe we would like another flag indicating that > we should automatically open a FileOpen dialog in the path we specified.
i think this should be covered by command-sequence lfun... >>> Some general comments on the LFUN: >>> >>> + R - Reload - reload the document after command execution \n >>> ... >>> + if (buffer && contains(flag, 'R') && !ensureBufferClean(view())) >>> + break; >>> ... >>> + if (contains(flag, 'R')) >>> + reloadBuffer(); >>> >>> I think and prefer that the first of these two should check for a flag >>> 'S' (or something else different from R). >>> >> >> whats wrong with R :) ? >> >> > According to the documentation, 'R' specifies whether to reload the buffer. > I can't see the relation with ensureBufferClean. reload buffer will discard any unsaved buffer and this is good indication for the user he may loose some data. iirc this in correspondence how the other vc function work. >Other way around, if it is > needed to save the buffer before executing the command, why would I like to > reload the buffer afterwards. this preserves user against forgeting on something > I thus argue having two separate flags for saving and reloading. you can use other lfuns for this. > Another thing I forgot is: > Wouldn't it be possible to skip the <PATH> argument when it is not needed. > As you can see TortoiseSVN wants it as a parameter. i'm not sure i understand here what you mean. using different number of params makes more troubles in code and i don't see the profit. you can simple simply put '.' if you are not concenrned in this parameter. pavel
