Commit:
vc-command DS "." "TortoiseProc /command:commit /path:$$p"

Revert:
vc-command DR "." "TortoiseProc /command:revert /path:$$p"

Checkout (does not really work yet):
vc-command R "." "TortoiseProc /command:checkout /path:$$p"

don't be decieved by the terminology, you want svn update and
not checkout.
svn checkout is now completely out of the lyx VC scope...

I just forgot adding 'update', but it is basically the same. And I was trying to add a checkout command. It works quite well, except that LyX does not which file top open. Maybe we would like another flag indicating that we should automatically open a FileOpen dialog in the path we specified.
Some general comments on the LFUN:

+ R - Reload - reload the document after command execution \n
...
+       if (buffer && contains(flag, 'R') && !ensureBufferClean(view()))
+               break;
...
+       if (contains(flag, 'R'))
+               reloadBuffer();

I think and prefer that the first of these two should check for a flag 'S' (or something else different from R).

whats wrong with R :) ?

According to the documentation, 'R' specifies whether to reload the buffer. I can't see the relation with ensureBufferClean. Other way around, if it is needed to save the buffer before executing the command, why would I like to reload the buffer afterwards.

I thus argue having two separate flags for saving and reloading.

Another thing I forgot is:
Wouldn't it be possible to skip the <PATH> argument when it is not needed. As you can see TortoiseSVN wants it as a parameter.

Vincent

Reply via email to