On Sun, Jan 11, 2009 at 11:19:42AM +0100, Andre Poenitz wrote:
> On Sun, Jan 11, 2009 at 03:18:37AM +0100, Uwe Stöhr wrote:
> > Andre Poenitz schrieb:
> >
> >>> + int num = QComboBox::count(); + for (int i = 0; i < num; i++) {
> >>> + if (QComboBox::itemText(i).contains("mu") > 0) {
> >>
> >> Shouldn't
> >>
> >> if (QComboBox::itemText(i).contains("mu"))
> >>
> >> be sufficient?
> >
> > You are right. I copied the code from the existing noPercents()
> > method. Corrected patch is attached.
> >
> >> Also the 'QComboBox::' qualification should not be necessary.
> >
> > LengthCombo.cpp uses this all over the place. I leave the decision to
> > you to clean up this file or not.
>
> Fair enough. Just submit then.
"to trunk" that means.
Andre', usually not talking about "branch".
