> Your patch has :
>
> - GOTOREF, GOTOBACK,
> + GOTOREF, GOTOBACK
>
> Is this really necessary ? I know for structures at least a trailing , is
> part of the standard, maybe it's different for enums.
If I have the following code in FormRef.h
enum GotoType {
GOTOREF, GOTOBACK,
};
the compiler complains with:
cxx: Warning: FormRef.h, line 56: trailing comma is nonstandard
GOTOREF, GOTOBACK,
---------------------------------^
I rekon it's pretty ugly, so losing the comma seems like a good idea.
> I'll have to watch out for this, as its standard practice in the linux
> kernel, and I do it without thinking.
Ahh! But I'm not running or compiling a linux kernel!
> doTree shouldn't even be there, it was debugging leftover. My patch from
> today removes it.
I'll continue with these compiles (even though I won't be able to link in the
resultant library) as they don't take very much time/effort and testing code
on more than one compiler is a Good Thing!
Keep up the good work!
Angus
