On Fri, 15 Sep 2000, Angus Leeming wrote:
> John,
> thanks for the advice. I have compiled the stuff in src/frontends/kde against
> kde-1.1.2, as you suggested. I used the DEC cxx compiler to test the code, so
> haven't tried to link. The code compiles fine with this compiler; see
> attached patch.
>
Your patch has :
- GOTOREF, GOTOBACK,
+ GOTOREF, GOTOBACK
Is this really necessary ? I know for structures at least a trailing , is
part of the standard, maybe it's different for enums. I'll have to watch
out for this, as its standard practice in the linux kernel, and I do it
without thinking.
doTree shouldn't even be there, it was debugging leftover. My patch from
today removes it. Of course the std::endl thing looks fine.
> Incidentally, "make clean" doesn't remove the *_moc.C files here. This maybe
> because I haven't done the configure properly. It may, however, be because
> things aren't set up properly. Perhaps you'd have a look.
You are right, I have added the moc files to the make clean target in the
attached patch, incremental to my previous one today.
thanks for the report !
john
--
"There is a fine line between genius and insanity. I have erased this line."
- Oscar Levant
Index: ChangeLog
===================================================================
RCS file: /usr/local/lyx/cvsroot/lyx-devel/ChangeLog,v
retrieving revision 1.529
diff -u -r1.529 ChangeLog
--- ChangeLog 2000/09/15 10:24:13 1.529
+++ ChangeLog 2000/09/15 15:21:36
@@ -1,3 +1,29 @@
+2000-09-15 John Levon <[EMAIL PROTECTED]>
+
+ * src/frontends/kde/Makefile.am: add
+ moc files to make clean
+
2000-09-15 John Levon <[EMAIL PROTECTED]>
* acconfig.h
Index: src/frontends/kde/Makefile.am
===================================================================
RCS file: /usr/local/lyx/cvsroot/lyx-devel/src/frontends/kde/Makefile.am,v
retrieving revision 1.7
diff -u -r1.7 Makefile.am
--- src/frontends/kde/Makefile.am 2000/09/14 09:09:56 1.7
+++ src/frontends/kde/Makefile.am 2000/09/15 15:21:37
@@ -15,6 +15,8 @@
DISTCLEANFILES = $(BUILTSOURCES) *.orig *.rej *~ *.bak core
+CLEANFILES = $(BUILTSOURCES)
+
libkde_la_OBJADD = \
../xforms/FormCommand.lo \
../xforms/FormDocument.lo \
