On Wed, Sep 05, 2007 at 09:27:26PM +0200, Abdelrazak Younes wrote:
> Andre Poenitz wrote:
> >On Wed, Sep 05, 2007 at 09:08:36PM +0200, Abdelrazak Younes wrote:
>
> >>Well, if that means that these dialogs (Toc, Citation, View source) move
> >>back to use the old scheme with QDialogView and company, I strongly
> >>disagree with the change.
> >
> >The only change is that they do not derive from the controller, but have
> >a controller pointer as member. The whole QDialogView stuff is gone.
>
> Fine then.
>
> >
> >In the long run we could/should think about merging controller and view
> >nevertheless. Reduces the number of classes by 50% and make those string
> >conversion orgies unnecessary...
>
> Well, even without the controller you'll still need to do the conversion
> in order to communicate with the core. But I guess I agree with the
> general idea. We'll see how it goes...
There's already a lot of small cleanup potential of the
- value = convert<double>(fromqstr(dialog_->widthED->text()));
+ value = widthED->text().toDouble();
variety left. Easy prey ;-)
Andre'
