On Wed, Sep 05, 2007 at 09:08:36PM +0200, Abdelrazak Younes wrote: > Andre Poenitz wrote: > >I am currently merging the two classes in all frontends/qt4/Gui*.h into > >a single one per *.h along with the necessary changes in the > >infrastructure. At the end of this we will still have MVC with seperate > >View and Controller classes and we will still even have a > >ButtonController, so this is not about destroying MVC (even if merging > >controllers and dialog would relly make sense in my opinion). > > > >LyX will be around 1800 lines slimmer after that particular change, (so > >we lost around 3000 lines within two weeks...) and the frontend code in > >a state that I'd consider much more maintainable than before. > > > >In any case, the change will be a bit disruptive. I expect the old > >dialogs to "just work" in the end, but anything that does not stick to > >the old scheme will receive/has already received some damage. This > >concerns mostly the new stuff for toc, listings, source view (i.e. > >everything that does not use setController() but direct inheritance and/or > >non QDialog base classes). As far as I can tell in all cases the > >respective developers are still around so I don't think the damage will > >be permanent (also the dialogs now are no more complicated...). > > Well, if that means that these dialogs (Toc, Citation, View source) move > back to use the old scheme with QDialogView and company, I strongly > disagree with the change.
The only change is that they do not derive from the controller, but have a controller pointer as member. The whole QDialogView stuff is gone. In the long run we could/should think about merging controller and view nevertheless. Reduces the number of classes by 50% and make those string conversion orgies unnecessary... > If it just mean that we'll just have to adapt > the interface, go ahead and commit it as soon as it is compilable. That's more or less the plan. Andre'
