Andre Poenitz wrote:
On Thu, Sep 06, 2007 at 12:16:15AM +0200, Abdelrazak Younes wrote:
Andre Poenitz wrote:
On Wed, Sep 05, 2007 at 09:08:36PM +0200, Abdelrazak Younes wrote:
Well, if that means that these dialogs (Toc, Citation, View source) move
back to use the old scheme with QDialogView and company, I strongly
disagree with the change.
The only change is that they do not derive from the controller, but have
a controller pointer as member.
It was a bit more than that... exactly what I feared:
class GuiViewSourceDialog : public GuiDialog, public Ui::ViewSourceUi
Consider this as a measure to make it compile. I really did not want to
try to understand how the new style dialogs worked.
OK.
Whereas it was
class GuiViewSourceDialog : public QWidget, public Ui::ViewSourceUi
I tried to make this dialog independent from the button controller, etc
and you put it back! I'd rather migrate all dialogs to my framework
quite frankly.
I am happy about every dialog that does not need a GuiDialog base.
So feel free to put there a QWidget base and make it compile again.
Good.
Abdel.
