Abdelrazak Younes wrote:
But why don't you review the branch instead? The incremental commit are
much more easier to grasp. Why do you insist on reviewing the final patch?
For one thing, because the final patch is what's going to go in in the end.
Secondly, almost as important as what goes in to the merge, is also what
*doesn't* go in: namely, all the development that has happened since
your branch diverged; by reviewing the commits on your branch, we still
have no way of making sure that when we merge back, we'll also have
everything that's been done on trunk, as well. I noticed two changes
that I have made in trunk which are being "undone" by your branch. I
doubt the only things missed are mine, given that I commit very little
compared to other people here...
Dov
