[EMAIL PROTECTED] wrote:
On Tue, 14 Aug 2007, Abdelrazak Younes wrote:
> > Remember that this discussion started with "if you have 10 minutes,
> > please merge my branch".
And you still think code review is bullshit.
Never said that, I am still waiting the review...
FYI: Regardless of your exact words[1], my impression of your attitude
towards review of your code is similar to what Jean-Marc wrote.
I stated maybe 10 times that I'd like comments on the incremental diffs
in my branch. I find it weird that I receive comments on the small
glitches before receiving any comments on the design. I am not
interested in the small details at this point.
To summarize my point: you will have to spend time studying the old code
before any comment becomes useful. I've done that and believe me, it's
horribly complicated and bug prone (just look at
BufferView::setBuffer()). My patch simplifies the code in charge of
loading and closing documents and their visualizations on screen. So,
unless you know already the old code, there's no point in studying it;
unless you want to waste time of course. Studying the new code would be
on the contrary very beneficial to me. That's why I said that focusing
on the cleanliness of the big patch is wrong. I stand on my point.
I'm glad this is not the case. Oh, wait... you didn't literally state
that you _don't_ think code review is bullshit... ;-)
I always welcome comments but most of the time I only receive requests
for explanation.
Abdel.
