On Mon, 13 Aug 2007, Abdelrazak Younes wrote:
No, as I said, the incremental svn diff are already available. Reviewing
such a big patch is masochistic.
Being ignorant, could you please tell me how you mean I shold access the
incremental diff? (Or point me to suitable instructions of course). I
wouldn't mind testing another approach to see if that's better.
Btw, it was a bit confusing that your mvc branch was obscured by all the
other cruft in
root/lyx-devel/branches/personal/younes/mvc
I was looking at the wrong source to begin with.
In addition, there's an ulterior motive to my approach: Some documentation
of the intended structure/design ends up in the source code rather than
hidden in the commit messages or the developers' list.
It is already more or less. More doxygen comments are always welcome of
course.
I thought I'd try and find some of that "more or less" documentation.
Not much in e.g. LyXView.cpp, but some in LyXView.h.
47 /**
48 * LyXView - main LyX window
49 *
50 * This class represents the main LyX window and provides
51 * accessor functions to its content.
52 *
53 * The eventual intention is that LyX will support a number
54 * of containing LyXViews. Currently a lot of code still
55 * relies on there being a single top-level view.
56 *
57 * Additionally we would like to support multiple views
58 * in a single LyXView.
59 */
This is the same as in trunk, so maybe you could point to documentation in
the code that explains the new structure? (I'm trying to learn!)
Documentation in the code is _very_ helpful to developers trying to
understand what it does (and what it is intended to do -- these doen't
necessarily coincide..).
I am always careful to document my code. There's a site somewhere that
do statistic on the svn commit. You will see there that my code/comment
ratio is one of the highest.
That's very good, I hope you aren't confusing commit messages with change
documentation, with documentation of design/API/etc? I don't think the
former is relevan for the latter.
/Christian
Bah... something is wrong with my keyboard, i's missing key strokes!
--
Christian Ridderström, +46-8-768 39 44 http://www.md.kth.se/~chr
