[EMAIL PROTECTED] wrote:
On Mon, 13 Aug 2007, Abdelrazak Younes wrote:
* Buffer: load all child documents in one go where it makes sense.
This has the advantage to call updateLabels() only once for the
master buffer and to get rid of the LyXView dependency. We can think
of maintaining a child document list in the future.
Now it is up to you to guess where it makes sense. Is the intent that
all child buffers are always loaded?
Yes. And this has always been like this. The difference is that we
load all the child documents at the same time instead of waiting that
the loading is asked by some insets.
Was the impact on really large
files been evaluated?
As I said, the loading happens anyway. Loading them preably make the
loading actually make the overall parsing _faster_.
When the loading happen matters to a user, it's not just a question of
total loading time.
The loading of child documents happens automatically (my patch doesn't
change this) when you do one of the following:
- latex export of the master document (and of course all latex based
view/export)
- docbook export of the master document (and of course all latex based
view/export)
- open the citation dialog from the master or one of the child docs.
- open the cross-reference dialog from the master or one of the child docs.
I don't know the effect of your changes, so the following depends on how
it works. However, if it means that when I open a huge multi-part
document like my thesis, I have to wait longer before I can start
working I'm not sure I'd like the change.
No, the child loading will happen only when you do one of the action
above. My patch didn't change that behavior, it just made the loading
happens faster, that's all.
Please note that start working may just mean fiddling with the master
document or going to a specific child document, i.e. actions that don't
require all child documents to have been opened.
See above.
Abdel.