[EMAIL PROTECTED] wrote:

> Author: baum
> Date: Mon Aug 13 08:56:20 2007
> New Revision: 19493
> 
> URL: http://www.lyx.org/trac/changeset/19493
> Log:
> Fix thinko: "$ac_test_CXXFLAGS" = "set" if CXXFLAGS was _not_ set.
> This broke the --enable-optimization switch.
> 
> This fix should probably go in 1.5 and trunk as well.
> 
> Modified:
>     lyx-devel/branches/personal/baum/BRANCH_1_4_X_GB/config/lyxinclude.m4
> 
> Modified:
> lyx-devel/branches/personal/baum/BRANCH_1_4_X_GB/config/lyxinclude.m4 URL:
>
http://www.lyx.org/trac/file/lyx-devel/branches/personal/baum/BRANCH_1_4_X_GB/config/lyxinclude.m4?rev=19493
>
==============================================================================
> --- lyx-devel/branches/personal/baum/BRANCH_1_4_X_GB/config/lyxinclude.m4
> (original) +++
> lyx-devel/branches/personal/baum/BRANCH_1_4_X_GB/config/lyxinclude.m4 Mon
> Aug 13 08:56:20 2007 @@ -231,8 +231,6 @@
>    CXX_VERSION="($gxx_version)"
>  
>    if test "$ac_test_CXXFLAGS" = set; then
> -    CXXFLAGS="$ac_save_CXXFLAGS"
> -  else
>        CFLAGS="$lyx_opt"
>        CXXFLAGS="$lyx_opt"
>      if test x$enable_debug = xyes ; then
> @@ -244,6 +242,8 @@
>          CXXFLAGS="-pg $CXXFLAGS"
>          LDFLAGS="-pg $LDFLAGS"
>      fi
> +  else
> +    CXXFLAGS="$ac_save_CXXFLAGS"
>    fi
>    if test "$ac_env_CPPFLAGS_set" != set; then
>      if test x$enable_warnings = xyes ; then

As I wrote in the comment this should probably go to trunk and 1.5 as well
(maybe with renaming this confusing "set"). This innocent bug made me run
an unoptimized LyX for months. I don't notice a big difference to the
optimized version in general, but for the citation dialog the unoptimized
version produces a ~10 second delay when opening it with a big bib file
(more than 5000 entries). The optimized version takes less than one second.


Georg

Reply via email to