On Sun, 12 Aug 2007, Abdelrazak Younes wrote:
For fuck sake, the commit logs are there to look at! Sorry Christian,
it's not against you but I've already gone through the lengthy process
of proving myself to Lars and others. I am simply not going to do it
again.
Don't worry, I don't take it personally. It isn't personal - it's about
the code that goes into stable/trunk, i.e. how it affects the application,
the users and other developers (no priorities implied).
If a change in a branch is so distributed/complicated/diffiult that it
can't be converted into several managable patches, something else is
needed. Perhaps some kind of overall documentation or design document
(complementing the commit/log messages)? That would at least help
other developers to review the changes inside the branch more
effectively. Has anyone other than you reviewed the branch?
How could I know? I am simply asking for help in merging this branch and
all I get is "prove us that this is the right thing to do". To this, I
say no, I am not going to prove anything. If nobody sees that my work is
beneficial to LyX, I'll simply maintain my own branch and forget about
you guys.
As I understand it, the preferred way to get help is to convince other
developers to review what you have done. Palatable patches is one way, but
there are surely others. You can of course maintain your branch, and
should do so if it's useful to you!
[*] According Andre', there's an exception in effect here at the
meeting where the particpants may commit at will... Since Andre' has
broken the build for me many times these days, I can see that he likes
the expection here, but also why it's a very good idea with reviews.
There should be no exception. I don't care about the meeting rules.
Although I'm not a major fan, I do see some reasons for it.
* Quicker/better communication and collaboration
* Faster progress
* Additional leeway is motivation to attend
* Immediate accountability
The last item means that when the build broke, I could just ask out loud
who did it and get it fixed. Something else that's different is the real
life interaction, which allows more efficient reviewing. It's actually
happening next to me as I'm writing this (Martin is showing his work to
Andre' in the sofa).
Best regards,
Christian
--
Christian Ridderström, +46-8-768 39 44 http://www.md.kth.se/~chr
