Lars Gullik Bjønnes wrote:
It is about having all developers on the same page, understanding the changes done in the lyx source and agreeing that this is the best approach.
I've already explained why this is the right approach. I am fad up of this discussion.
A large un-split, patch are hard to grasp and understand, and makes a decent review practically impossible, especially when there are little information about the goal of the patch-set. And I have looked at the commit logs... did not tell me much.
Then look at the diff? If you are not able to understand the log and the diff then it is because you don't know this stuff. And you know what? That's fine! I claim to be an expert in this stuff now.
Abdel.
