Jean-Marc Lasgouttes schrieb:
http://bugzilla.lyx.org/show_bug.cgi?id=3764

This is an important privacy bug, that should be fixed before 1..50
IMO. In the following patch, I tried to be as unintrusive as possible.

Jean-Marc, thank you very much for stepping forward!

The
other authors of the list are replaced by empty entries. Indeed, it is
not possible/easy to renumber the authors on the fly if I want to
remove one of them. OTOH, the \author entries do not contain an author
id, and it is therefore necessary to insert empty authors for unused
ids.
A consequence of this patch is that the list of authors grows with every load-buffer-save-buffer cycle. Luckily, hard disk space is longer an issue :-)

Finally, I think that a policy should be defined in AuthorList to reuse empty
author entries.
With our current implementation, the active user (i.e., the one editing the document) has always author id = 0. Unfortunately, our code base does not permit a more flexible approach without significant code changes.

What I had in mind - but never managed to realize - is a relabelling function. I.e., every author id is mapped on a new author id before saving (and only for saving). This way, we would be able to kick out unused authors.

Nevertheless, the patch seems to fit the bill. Please please test it,
I am not sure at all I did not make mistakes.
I will do so before the weekend. Question: Does your patch also scan nested insets? I can't see any related code.

Michael

Reply via email to