Jean-Marc,
Jean-Marc> Something like that.
Great. Very compact and non-intrusive patch!
Jean-Marc> I tested briefly with 3 different
Jean-Marc> authors, and I think something is wrong (I think it was
Jean-Marc> already wrong before, actually). I do not see how current
Jean-Marc> author could always be index 0 (which is written in the
Jean-Marc> file) if the file is really edited by several authors.
Did you encounter a real problem or do you just feel uncomfortable? My
understanding of the author list mechanism is as follows: When loading a
document, an author list is created and (in BufferParams:Impl::Impl)
filled with one entry (=> current author index = 0). When parsing the
author list from the document, each author is record()'ed in the author
list. Moreover, the author index in the document is mapped on the author
index in the buffer's author list. See field author_map in
BufferParams.cpp. This mechanism is also responsible for merging
identical (unused) authors although it wasn't designed for that purpose.
I.e. the author list will not increase endlessly.
IMHO, your patch should work correctly. Could someone else test it, too,
please?
Thanks in advance,
Michael
