Abdelrazak Younes wrote:
Georg Baum wrote:
And then look at the very recent marginal bug: AFAIK (correct me if I am
wrong) this happened because of missing review of the insetName -> name
change.
Small correction: this bug appeared in the InsetOld -> Inset transfer
with the removal of setInsetName(). Nothin to do with the insetName ->
name change.
A simple and safe looking change caused a serious bug.
About this particular one, I proposed to make the method pure virtual,
any objection?
If I do that, here is the list of unamed insets, could someone review
them please?
'lyx::InsetVSpace' : cannot instantiate abstract class
'lyx::InsetUrl' : cannot instantiate abstract class
'lyx::InsetTOC' : cannot instantiate abstract class
'lyx::InsetNewline' : cannot instantiate abstract class
'lyx::InsetText' : cannot instantiate abstract class
'lyx::InsetTabular' : cannot instantiate abstract class
'lyx::InsetSpecialChar' : cannot instantiate abstract class
'lyx::InsetSpace' : cannot instantiate abstract class
'lyx::InsetRef' : cannot instantiate abstract class
'lyx::InsetPagebreak' : cannot instantiate abstract class
'lyx::InsetClearPage' : cannot instantiate abstract class
'lyx::InsetClearDoublePage' : cannot instantiate abstract class
'lyx::InsetNomencl' : cannot instantiate abstract class
'lyx::InsetPrintNomencl' : cannot instantiate abstract class
'lyx::InsetNewline' : cannot instantiate abstract class
'lyx::InsetLine' : cannot instantiate abstract class
'lyx::InsetLabel' : cannot instantiate abstract class
'lyx::InsetIndex' : cannot instantiate abstract class
'lyx::InsetPrintIndex' : cannot instantiate abstract class
'lyx::InsetInclude' : cannot instantiate abstract class
'lyx::InsetHFill' : cannot instantiate abstract class
'lyx::InsetGraphics' : cannot instantiate abstract class
'lyx::InsetFloatList' : cannot instantiate abstract class
'lyx::InsetExternal' : cannot instantiate abstract class
'lyx::InsetCitation' : cannot instantiate abstract class
'lyx::InsetCaption' : cannot instantiate abstract class
'lyx::InsetBibtex' : cannot instantiate abstract class
'lyx::InsetBibitem' : cannot instantiate abstract class
Abdel.
