Lars Gullik Bjønnes wrote:
Welcome back!
Georg Baum <[EMAIL PROTECTED]> writes:
| > Tested. Huge difference. Now the screen does not scroll faster than it
| > is able to draw. IMHO much better. A fast screen might not be able to
| > scroll as fast as it could have, but on slower screens it makes a huge
| > difference to the usability of page scrolling at least.
|
| What is a slow screen for you? A remote X server? If yes over what
| connection? IMO LyX should still be usable over a not so fast connection,
| e.g. a 10 MBit/s network or a faster DSL line.
Yes. Quite a bit of my X work is done over VNC. With the r16046
reverted Pg Up/Down is usable for scrolling.
Please test this patch instead. If it is still not usable, please give
me numbers. A profile would be nice also. What is the use case? Hold
PageDown key pressed and wait? Is the performance OK with multiple
PageDown keypress?
|
| > I think the r16046 should be reverted and turned on by default.
|
| Would that have any drawbacks?
Max scrolling speed will be reduced. Apart from that I don't really
know of any. (But I am sure others will chime in)
This buffering code is way too complicated for my taste and it does not
feel right (to me at least). I am sure we can do better. Therefore I am
not in favour of putting this back in and I am also not in favour of
making this the default.
Abdel.
Index: GuiWorkArea.C
===================================================================
--- GuiWorkArea.C (revision 17288)
+++ GuiWorkArea.C (working copy)
@@ -446,7 +446,7 @@
void GuiWorkArea::update(int x, int y, int w, int h)
{
- viewport()->repaint(x, y, w, h);
+ viewport()->update(x, y, w, h);
}
