Bo Peng wrote:
No, this was not about naming. What I meant was: LyX does not care
whether
the selection was set from within or not. It simply sends the
selection to
the X server when it has one, and gets the current selection back when it
is requested. Therefore a Selection::isInternal() method is only
confusing, because it is not needed. Besides that the comment is wrong.
This is feasible under X11, but I guess qt/win does not have system
selection buffer, right? That is to say, keeping internal selection is
the only way to do middle-button paste under windows.
Agreed.
This could even be implemented without any #ifdef by simply using
qApp->clipboard()->supportsSelection(), and would work automatically on
all platforms that don't have a selection. This way, no preference
setting
would be needed, and the behaviour on windows and X11 would be as
identical as possible. Or did I miss anything?
Do you want C-v to paste selection? This is not the same under X11. I
mean, under windows, middle-button paste would better work, but only
paste selection, and these operations should have nothing to do with
windows clipboard.
Please read the whole thread and my patch proposal before commenting any
further.
Abdel.
