Georg Baum wrote:
Am Mittwoch, 3. Januar 2007 12:33 schrieb Abdelrazak Younes:
It was easy so I've done it. It works quite well. Could you please it on
X11 and verify that I did not miss something?
What I don't like is that you used the fake selection even if on systems
that have a real one.
Well, I thought it was good to avoid the unnecessary conversion and
end-of-line filtering. I also thought that instead of a docstring we
could store a CursorSlice for the internal pasting. This will have the
benefit to preserve the LyX formatting and layout. But of course this is
against the "simple mental model". OTOH, it is clearly a nice end-user
feature feature: why do I have to loose all the formatting when
copy&paste with the mouse?
Please note that right now mouse pasting preserve the formatting because
the choice is made in LFUN_MOUSE_PRESS:
if (cmd.button() == mouse_button::button2) {
if (paste_internally)
lyx::dispatch(FuncRequest(LFUN_PASTE));
else
lyx::dispatch(FuncRequest(LFUN_PRIMARY_SELECTION_PASTE,
"paragraph"));
}
I simply propose to transfer this code to the X selection handler, and
that is GuiSelection.
That is aginst the "simple mental model": If the
selection is empty, then it is empty, and the middle mouse button does not
paste anything. What I had in mind was rather something like the attached.
Please think a bit more about it.
Abdel.
