>>>>> "Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:

>>  Personally, I like the approach, although some details (like being
>> forced to pass the address of the lyxtext instead of hiding such
>> technicalities) make the code a bit more difficult to read.

Abdelrazak> Would you prefer to pass a reference instead?

Yes, less characters :) Actually an inline helper function would
probably be better that exposing text_metrics_[&foo][bar], at least in
my eyes.

Abdelrazak> As for the optimization (like those repeated LyXText
Abdelrazak> access), I will do that out once this is in. But, as I
Abdelrazak> said and a previous post, I am just unrolling the
Abdelrazak> spaghetti for now. After that there is a lot of room for
Abdelrazak> code simplification all over the place.

I agree with this approach.

JMarc

Reply via email to