Jean-Marc Lasgouttes wrote:
"Abdelrazak" == Abdelrazak Younes <[EMAIL PROTECTED]> writes:
Abdelrazak> Abdelrazak Younes wrote:
Hello,
Here is the first draft of the model/view separation of the
Paragraph class. It is mostly working already execept for
Copy&Paste and MultipleView.
Abdelrazak> I've solve the C&P issue and many others. In single window
Abdelrazak> mode, the attached patch is very stable, I did extensive
Abdelrazak> testing but could not make it crash (including with DEPM
Abdelrazak> action triggered). There's no painting problem either.
Abdelrazak> From this point I'd welcome any additional testing. But I
Abdelrazak> really think it is ready for inclusion.
Abdelrazak> So, objections?
Personally, I like the approach, although some details (like being
forced to pass the address of the lyxtext instead of hiding such
technicalities) make the code a bit more difficult to read.
Would you prefer to pass a reference instead?
As for the optimization (like those repeated LyXText access), I will do
that out once this is in. But, as I said and a previous post, I am just
unrolling the spaghetti for now. After that there is a lot of room for
code simplification all over the place.
Anyway, the decision is Jose's to make.
Yep and I hope he is not too far away so that I can work some more on
this issue. If he takes too long to answer I will probably put that into
a branch but I'd prefer not.
Abdel.
