>>>>> "Dekel" == Dekel Tsur <[EMAIL PROTECTED]> writes:

Dekel> If you want to move code into InsetQuotes, you can also move
Dekel> the code that sets the value of c into InsetQuotes, and delete
Dekel> insertCorrectQuote. I'll let you decide if it this a better way
Dekel> than the one I used.

Dekel> I've changed the code as you requested. The attached patch also
Dekel> fixes the following: 

I do not think we should do it this way. The quotes inset needs to be
improved anyway, and the problems you have are not really related to
hebrew, but to language support. I think we should have some language
files like french.lng, hebrew.lng, which contain:

- the quote style, for both normal and inner quotes (this will often
  be double and single, but needn't be so). 

- the default character encoding both for latex and X fonts. I'm not
  sure our font systems allows for multiple encodings yet.

- a translation of common latex variables like \chaptername, taken
  from babel files. These would be then used in layout files.

- maybe some special preamble commands when invoking babel is not
  enough. 

- what else?

While we do not want to put all of it in right now, I think the quotes
chnage should be done in this setting. One possibility could be to
have four kind of quotes (left, right, inner left and inner right) and
let LyX display/output them depending on the current language. Of
course, this is not really backward compatible with old-style quotes,
but I in the current settings quotes insets are not really quotes...

I used to have a file containing different languages conventions for
quotes, but of course I can't find it anymore.

What do other think? How should quotes be handled? What other
language-specific settings should we add?

Dekel> 1. Generate a correct latex file when
Dekel> there is an English text with a footnote that starts with a
Dekel> Hebrew paragraph, or vice versa 

I'm willing to apply this one, if you can provide a patch just for
that (I don't want to apply it wrongly).

Dekel> 2. Change input encoding to
Dekel> "default" when rtl_support is set (maybe a better way is to add
Dekel> a lyxrc options for input encoding?) 

Like for quotes, we should search a better solution. Note that you can
use the Layout->Save_layout_as_default to have this as a default for
new files.

Dekel> 3. And most importantly, add my name to lib/CREDITS :-)

This one is in.

Dekel> PS: Don't forget to add the Hebrew keymap (and layouts) to the
Dekel> CVS.

They are in.

JMarc

Reply via email to