On Mon, Feb 07, 2000 at 07:15:14PM +0100, Lars Gullik Bj&resh;nnes wrote:
> | @@ -612,8 +612,13 @@ void BufferView::insertCorrectQuote()
> | c = text->cursor.par->GetChar(text->cursor.pos - 1);
> | else
> | c = ' ';
> | + LyXDirection direction = text->real_current_font.getFontDirection();
> |
> | - insertInset(new InsetQuotes(c, buffer()->params));
> | + insertInset(new InsetQuotes(c,
> | + (direction == LYX_DIR_LEFT_TO_RIGHT)
> | + ? buffer()->params.quotes_language
> | + : InsetQuotes::SwedishQ,
> | + buffer()->params.quotes_times));
>
> What can't all this be done in InsetQoutes, instead of this horrible
If you want to move code into InsetQuotes, you can also move the code that
sets the value of c into InsetQuotes, and delete insertCorrectQuote.
I'll let you decide if it this a better way than the one I used.
> call? Ok, at least use some temporary variables for this.
I've changed the code as you requested.
The attached patch also fixes the following:
1. Generate a correct latex file when there is an English text with a footnote
that starts with a Hebrew paragraph, or vice versa
2. Change input encoding to "default" when rtl_support is set
(maybe a better way is to add a lyxrc options for input encoding?)
3. And most importantly, add my name to lib/CREDITS :-)
PS: Don't forget to add the Hebrew keymap (and layouts) to the CVS.
patch.gz
