DavidSpickett wrote:

Cool, some good improvements so far.

> Instead of this, should I call the next dump function with name parameter and 
> handle the name=nullptr in the PrintRed function.

It would be a good idea to do this yes. I left some comments suggesting things 
to check there.

I would do that and remove the redundant `else`s, then move on to replacing 
PrintRed with the built in function I mentioned.

https://github.com/llvm/llvm-project/pull/69422
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to