DavidSpickett wrote: > Can you please confirm if passing the pointer to CommandInterpreter object in > PrintRed function to get the use-color options a good idea?
Yes but it can be better :) See my comments. > Are the test cases good enough and also does the future plan sounds Okay? I suggested one more test case, otherwise they look good to me. https://github.com/llvm/llvm-project/pull/69422 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits