https://github.com/taalhaataahir0102 commented:
Hi David! We're done with point no. 1 i.e., extending the existing dump
functions by adding name (searched symbol) argument in the function definition.
Can you please have a look at the changes. Also here I'm doing a lot of this in
these dump functions:
if(name) {Pass name to next dump function}
else {Use the next dump function without name}
Instead of this, should I call the next dump function with name parameter and
handle the name=nullptr in the PrintRed function. Because at the end, the
program is going to land in the PrintRed function in the case of if. Even if I
land the program at the PrintRed function in case of else as well, will it be
okay?
Then instead of having writing if else in every dump function, I'll have to
write this in PrintRed function only:
if(name == nullptr){print without Red}
else(){Print with Red}
Also, Can you please confirm if the current version is done the right way as
per you suggested :)
Next: We will be working on point 2 (updating PrintRed function) and point 3
(Making test cases) and will update you shortly.
https://github.com/llvm/llvm-project/pull/69422
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
