labath accepted this revision.
labath added a comment.

That looks great. I have just one small nit. I think the test would read better 
if you made the names of temporary `TemplateArgument` objects more descriptive 
-- i.e. encode the kind and value information in the name. For example. 
`int47Arg` for an integer template argument whose value is 47, and `intTypeArg` 
for a type template argument (where `int` is the "value").


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D140030/new/

https://reviews.llvm.org/D140030

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to