labath added a comment.
I think that test should just be rewritten to not modify the object in such a
way. Instead of cumulatively modifying a single object, it could just create a
fresh one each time. That will also make it clearer what is being tested. And
I think it's fair game to add some constructors to the production object to
make that easy.
For example, instead of
// long sequence of manipulator operations
ExpectNewTemplate("<typename T, long...> (T = int, long = 1)", infos);
it could do something like
ExpectNewTemplate("<typename T, long...> (T = int, long = 1)",
TemplateParameterInfos({{"T", intType}}, /*pack_name=*/???,
/*pack=*/TemplateParameterInfos(???));
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140030/new/
https://reviews.llvm.org/D140030
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits