jasonmolenda added a comment.

One small comment on the updated test: surprisingly SBSymbol doesn't have a 
GetSymbolSize(), probably because it's a computed value and it's possible that 
we could not compute it, or the heuristic may be incorrect in a stripped 
binary, so I get the start & end address and calculate it manually.  Symbol 
byte sizes are calculated by lldb by looking at the next symbol's file address 
in the symbol table, or the end of the section.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130534/new/

https://reviews.llvm.org/D130534

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to