DavidSpickett added a reviewer: DavidSpickett.
DavidSpickett added inline comments.
================
Comment at:
lldb/test/API/functionalities/multiple-slides/TestMultipleSlides.py:34
+
+ # View the first element of `first` and `second` with
+ # a load address .
----------------
Is it worth checking here that the value of `&first` has actually changed, or
is sliding in general tested elsewhere?
================
Comment at: lldb/test/API/functionalities/multiple-slides/main.c:2
+int first[2048] = { 5 };
+int second[2048] = { 6 };
+int main() {
----------------
2048 is a random number or are you fitting into some page size or just a
distance big enough to prevent some accidentally correct but wrong behaviour by
lldb?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130534/new/
https://reviews.llvm.org/D130534
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
