labath added inline comments.
================ Comment at: lldb/test/Shell/SymbolFile/DWARF/dwarf5-implicit-const.s:3 + +# UNSUPPORTED: system-darwin, system-windows +# REQUIRES: x86 ---------------- jankratochvil wrote: > labath wrote: > > I hope these are not necessary, since you don't run the code here. > OK, removed: > ``` > -# UNSUPPORTED: system-darwin, system-windows > -# REQUIRES: x86 > ``` > We will see after all the bots run again. Sorry, I only meant the system-*** thingies. The `REQUIRES: x86` thingy was correct, as it will cause the test to be skipped if someone completely disables x86 support (via LLVM_TARGETS_TO_BUILD). That said, no bot actually builds lldb in that way, so I'm sure we have a lot of tests which are missing this clause. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98197/new/ https://reviews.llvm.org/D98197 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
