jankratochvil marked 2 inline comments as done. jankratochvil added a comment.
In D98197#2613149 <https://reviews.llvm.org/D98197#2613149>, @labath wrote: > Could you simplify the test case? done > I guess we should also delete > `test/Shell/Breakpoint/implicit_const_form_support.test`, as it's not very > useful (the numbers it checks come from the line table, not from the implicit > constants). I have not deleted it myself; I find non-racy simple tests to be always good as they may catch some completely unrelated regression in the future. ================ Comment at: lldb/test/Shell/SymbolFile/DWARF/dwarf5-implicit-const.s:3 + +# UNSUPPORTED: system-darwin, system-windows +# REQUIRES: x86 ---------------- labath wrote: > I hope these are not necessary, since you don't run the code here. OK, removed: ``` -# UNSUPPORTED: system-darwin, system-windows -# REQUIRES: x86 ``` We will see after all the bots run again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98197/new/ https://reviews.llvm.org/D98197 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
