jasonmolenda added a comment.

Hahaha I remember looking at this constructor and expecting to find an 
uninitialized ivar, but it was initialized correctly and I went to look for 
another place where the bug might be.  I think I see why there's some confusion 
-- this change landed Thrusday:

commit 642cb7865f35ad7dbac78d716fcddaff561e8639 
<https://reviews.llvm.org/rG642cb7865f35ad7dbac78d716fcddaff561e8639>
Author: Benjamin Kramer <benny....@googlemail.com>
Date:   Wed Aug 26 13:25:41 2020 +0200

  Copy m_plan_is_for_signal_trap member.
  
  Otherwise it would stay uninitialized. Found by msan.

doing exactly that.  When I was looking at the sources, that fix was already 
present.  I think we can close this phab?  I'm glad we would have found & fixed 
it even if Benjamin hadn't found it with msan. :)


Repository:
  rLLDB LLDB

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86417/new/

https://reviews.llvm.org/D86417

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to