labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

This looks good now. Thanks for your patience.



================
Comment at: 
lldb/test/API/tools/lldb-vscode/breakpoint-events/TestVSCode_breakpointEvents.py:68
+                                                      [main_bp_line])
+        if response:
+            breakpoints = response['body']['breakpoints']
----------------
Under what conditions can `response` be None? Should this maybe be 
`assertIsNotNone(response)` instead ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73665/new/

https://reviews.llvm.org/D73665



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to