clayborg added a comment. In D73665#1848755 <https://reviews.llvm.org/D73665#1848755>, @labath wrote:
> This is not ideal, but if that's what vscode wants, then I guess we just have > to do it. > > However, are you sure that this is all that needs to be done here. It seems > like also the handling of eBreakpointEventTypeLocationsAdded/Removed events > in EventThreadFunction should be changed too. Otherwise, I think the whole > breakpoint will disappear whenever a single location goes away... That is the nice thing about this fix: anyone that reports a breakpoint uses: llvm::json::Value CreateBreakpoint(lldb::SBBreakpointLocation &bp_loc) And this is the function I fixed! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73665/new/ https://reviews.llvm.org/D73665 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
