[Lldb-commits] [PATCH] D63745: [CMake] Check that a certificate for lldb is present at build time.

[Davide Italiano via Phabricator via lldb-commits]

davide created this revision.
davide added reviewers: JDevlieghere, sgraenitz, aprantl, friss.
Herald added a subscriber: mgorny.
Herald added a project: LLDB.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D63745

Files:
  lldb/CMakeLists.txt


Index: lldb/CMakeLists.txt
===================================================================
--- lldb/CMakeLists.txt
+++ lldb/CMakeLists.txt
@@ -72,6 +72,20 @@
     message(FATAL_ERROR "LLDB test compilers not specified.  Tests will not 
run")
   endif()
 
+  # On MacOS, debugserver needs to be codesigned. Check if we have a 
certificate instead
+  # of failing in the middle of the build.
+  if(CMAKE_SYSTEM_NAME MATCHES "Darwin" AND TARGET debugserver)
+    execute_process(
+      COMMAND security find-certificate -Z -p -c lldb_codesign 
/Library/Keychains/System.keychain
+      RESULT_VARIABLE cert_return
+      OUTPUT_QUIET
+      ERROR_QUIET)
+
+    if (cert_return)
+      message(FATAL_ERROR "Certificate for debugserver not found. Run 
scripts/macos-setup-codesign.sh")
+    endif()
+  endif()
+
   set(LLDB_TEST_DEPS lldb)
 
   # darwin-debug is an hard dependency for the testsuite.



Index: lldb/CMakeLists.txt
===================================================================
--- lldb/CMakeLists.txt
+++ lldb/CMakeLists.txt
@@ -72,6 +72,20 @@
     message(FATAL_ERROR "LLDB test compilers not specified.  Tests will not run")
   endif()
 
+  # On MacOS, debugserver needs to be codesigned. Check if we have a certificate instead
+  # of failing in the middle of the build.
+  if(CMAKE_SYSTEM_NAME MATCHES "Darwin" AND TARGET debugserver)
+    execute_process(
+      COMMAND security find-certificate -Z -p -c lldb_codesign /Library/Keychains/System.keychain
+      RESULT_VARIABLE cert_return
+      OUTPUT_QUIET
+      ERROR_QUIET)
+
+    if (cert_return)
+      message(FATAL_ERROR "Certificate for debugserver not found. Run scripts/macos-setup-codesign.sh")
+    endif()
+  endif()
+
   set(LLDB_TEST_DEPS lldb)
 
   # darwin-debug is an hard dependency for the testsuite.

_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits