clayborg added inline comments.
================
Comment at: source/Core/ValueObject.cpp:1719
+ // artificial.
return GetVariable() && GetVariable()->IsArtificial();
}
----------------
jingham wrote:
> clayborg wrote:
> > Things brings the questions: do we really need to filter these variables? I
> > wouldn't mind seeing "_cmd" and any other defaulted objective C variables
> > in the IDE. This seems like a lot of work to go through to just stop
> > showing "_cmd". Any variables for the language object ("self" for ObjC or
> > "this" for C++) are marked as artificial so we want to see these. If that
> > is the case, we can remove this all together.
> The reason for having a whitelist as well as suppressing artificial variables
> is so that we can show self & _cmd while still suppressing the really
> artificial variables like the ones used to track dynamic array sizes and
> swift metadata symbols. I don't think we want to show the latter.
Sounds good, my objection is removed. Still kind of weird that we
runtime->IsRuntimeSupportValue() from one language and
runtime->IsWhitelistedRuntimeValue() from another. I know why we do it, but it
still seems a bit weird.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63240/new/
https://reviews.llvm.org/D63240
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
