jingham added a comment.

I have no problem with the change in general.  However, you've introduced the 
possibility of name collision between convenience type definition in various 
languages.  So it would be good to run through the persistent DECL's for ALL 
the supported languages and report collisions.  Probably also need to add a -l 
flag to pick a language?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62797/new/

https://reviews.llvm.org/D62797



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to