xiaobai marked an inline comment as done.
xiaobai added inline comments.

================
Comment at: include/lldb/Expression/ExpressionVariable.h:235-236
 
+  virtual bool SetCompilerTypeFromPersistentDecl(ConstString type_name,
+                                                 CompilerType &compiler_type) 
= 0;
+
----------------
labath wrote:
> It would be better if this would return `Optional`(or 
> `Expected`)`<CompilerType>`
Let me try that out, I'll update this later.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62797/new/

https://reviews.llvm.org/D62797



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to