You can probably revert it. BTW, is the bot public? I would like to understand whether I broke something after I commit.
-- Davide On Thu, Sep 6, 2018 at 11:21 AM Stella Stamenova via Phabricator via lldb-commits <lldb-commits@lists.llvm.org> wrote: > > stella.stamenova added a comment. > > This change causes one of the LLDB tests to fail on Windows. More > specifically: > > ******************** > FAIL: lldb :: Settings/TestDisableColor.test (42646 of 43956) > ******************** TEST 'lldb :: Settings/TestDisableColor.test' FAILED > ******************** > Script: > -- > : 'RUN: at line 1'; > E:\_work\36\b\LLVMBuild\Release\bin\lldb.EXE -S > E:/_work/36/s/llvm/tools/lldb/lit/lit-lldb-init -x -b -s > E:\_work\36\s\llvm\tools\lldb\lit\Settings\TestDisableColor.test | > E:\_work\36\b\LLVMBuild\Release\bin\FileCheck.EXE > E:\_work\36\s\llvm\tools\lldb\lit\Settings\TestDisableColor.test > -- > Exit Code: 1 > > Command Output (stdout): > -- > $ ":" "RUN: at line 1" > $ "E:\_work\36\b\LLVMBuild\Release\bin\lldb.EXE" "-S" > "E:/_work/36/s/llvm/tools/lldb/lit/lit-lldb-init" "-x" "-b" "-s" > "E:\_work\36\s\llvm\tools\lldb\lit\Settings\TestDisableColor.test" > $ "E:\_work\36\b\LLVMBuild\Release\bin\FileCheck.EXE" > "E:\_work\36\s\llvm\tools\lldb\lit\Settings\TestDisableColor.test" > # command stderr: > ##[error]llvm\tools\lldb\lit\Settings\TestDisableColor.test(7,10): Error > GDC2C77F0: CHECK: expected string not found in input > > 1>E:\_work\36\s\llvm\tools\lldb\lit\Settings\TestDisableColor.test(7,10): > error GDC2C77F0: CHECK: expected string not found in input > [e:\_work\36\b\LLVMBuild\check-all.vcxproj] > > # CHECK: use-color (boolean) = false > > ^ > > <stdin>:1:1: note: scanning from here > > (lldb) command source -s 0 > 'E:/_work/36/s/llvm/tools/lldb/lit/lit-lldb-init' > > ^ > > <stdin>:9:1: note: possible intended match here > > use-color (boolean) = true > > ^ > > > Repository: > rL LLVM > > https://reviews.llvm.org/D51615 > > > > _______________________________________________ > lldb-commits mailing list > lldb-commits@lists.llvm.org > http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits