zturner added inline comments.
================ Comment at: source/Core/Debugger.cpp:819 + consoleMode |= ENABLE_VIRTUAL_TERMINAL_PROCESSING; + SetUseColor(SetConsoleMode(hConsole, consoleMode)); +#endif ---------------- xbolva00 wrote: > Should I rewrite it to more clear version like > > bool ansi_supported = SetConsoleMode(hConsole, consoleMode); > SetUseColor(ansi_supported); > > ? Shouldn't we change this to call `llvm::sys::Process::UseANSIEscapeCodes(true);`? ================ Comment at: source/Core/Debugger.cpp:53 #include "lldb/Host/windows/PosixApi.h" // for PATH_MAX +#include "windows.h" #endif ---------------- This should be `#include "lldb/Host/windows/windows.h"`. Otherwise you're getting the system `windows.h` file. If that's what you wanted, then it should be `<windows.h>` instead of `"windows.h"`, but that's never what you want, we should always be including LLDB's wrapper around windows.h instead. https://reviews.llvm.org/D51615 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
