labath added a comment.

In https://reviews.llvm.org/D47235#1109580, @zturner wrote:

> In https://reviews.llvm.org/D47235#1109219, @labath wrote:
>
> > I guess it would be nice to encapsulate this in some sort of a plugin 
> > (since the setting is used from the clang expression parser plugin, I guess 
> > this would be the natural home for it) , but I haven't looked in detail at 
> > could that work. What I do know is that we already have the ability to 
> > inject settings from within a plugin (see 
> > SymbolFileDWARF::DebuggerInitialize). Maybe that would work here too?
>
>
> I agree that a clang plugin seems like the "real" solution, I had come to the 
> same conclusion yesterday.  But that is a significant amount of work 
> obviously.


Is it that much work? We already have a clang (well, "clang expression parser" 
plugin). Getting **all** of the clang dependencies into that plugin is a 
completely different story, but I am hoping that simply getting this particular 
setting to live there would be just a matter of cargo-culting some code from 
SymbolFileDWARF.


https://reviews.llvm.org/D47235



_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to