aprantl added inline comments.
================ Comment at: source/Core/ModuleList.cpp:94 - llvm::SmallString<128> path; - clang::driver::Driver::getDefaultModuleCachePath(path); - SetClangModulesCachePath(path); + assert(!g_default_clang_modules_cache_path.empty()); + SetClangModulesCachePath(g_default_clang_modules_cache_path); ---------------- zturner wrote: > I don't think this should be an assert. After all, if the whole point is to > make LLDB usable in situations where clang is not present, then someone using > it in such an environment would probably never call the static function to > begin with. So I think we should just remove the assert and set it to > whatever the value happens to be (including empty) The assertion enforces that ModuleListProperties::Initialize() has been called. If we want to make it more convenient, we can add a default argument `= "dummy"` for clients that don't link against clang. https://reviews.llvm.org/D47235 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
