vsk added a comment.
I'm concerned about the time it takes to run the test suite. If we can get
decent test coverage of this patch without adding a new debug info flavor,
that'd be ideal.
================
Comment at: packages/Python/lldbsuite/test/lldbtest.py:718
self.getBuildDirBasename())
-
-
+
+
----------------
clayborg wrote:
> davide wrote:
> > spurious whitespaces, please revert.
> It is removing spurious whitespaces and there are other changes in this file.
> Most editors these days will remove spurious spaces and we should strive to
> remove them where possibly no?
No, we generally avoid making changes that are unrelated to the patch, as they
make patch review and subsequent merges harder.
================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.h:58
+ m_start -= offset;
+ }
+
----------------
Please clang-format your diffs.
https://reviews.llvm.org/D32167
_______________________________________________
lldb-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
